Fix use of Path in find_outliers script. #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You may or may not need this pull-request. There was a bug in the file `scripts/find_outliers.py` where the code uses a `fname` expecting a string, but in fact, by default, it will get a `Path` object. You may have found and fixed that bug, in which case, you do not need this PR. If you haven't already found and fixed this bug, then do merge this pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You may or may not need this pull-request.
There was a bug in the file
scripts/find_outliers.pywhere the codeuses a
fnameexpecting a string, but in fact, by default, it will geta
Pathobject.You may have found and fixed that bug, in which case, you do not need
this PR.
If you haven't already found and fixed this bug, then do merge this pull
request.